Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

framework for partial compile result processing #10

Merged
merged 1 commit into from
Nov 15, 2023
Merged

framework for partial compile result processing #10

merged 1 commit into from
Nov 15, 2023

Conversation

tanmaykm
Copy link
Member

Added a AST walker for partial compile result, and a visitor implementation that can translate it to SQL conditions. A more formal implementation of what was done in #9.

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023

Codecov Report

Attention: 51 lines in your changes are missing coverage. Please review.

Comparison is base (9b2b55f) 56.97% compared to head (3bfc181) 60.52%.

Files Patch % Lines
src/utils/ast.jl 63.84% 47 Missing ⚠️
src/utils/ast_walker.jl 62.50% 3 Missing ⚠️
src/utils/sql.jl 98.38% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #10      +/-   ##
==========================================
+ Coverage   56.97%   60.52%   +3.54%     
==========================================
  Files          34       37       +3     
  Lines         788      988     +200     
==========================================
+ Hits          449      598     +149     
- Misses        339      390      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Added a AST walker for partial compile result, and a visitor implementation that can translate it to SQL conditions.
A more formal implementation of what was done in #9.
@tanmaykm tanmaykm merged commit ea327ed into main Nov 15, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants